Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Move viewport and scissor to WebGPU convention - top-left #29249

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Aug 28, 2024

Related issue: #29162 (comment)

Description

Update viewport and scissor to WebGPU convention, using top-left, instead of the bottom-left.

@sunag sunag added this to the r168 milestone Aug 28, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
685.4 kB (169.7 kB) 685.4 kB (169.7 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
462 kB (111.4 kB) 462 kB (111.4 kB) +0 B

@sunag sunag marked this pull request as ready for review August 28, 2024 22:40
@sunag sunag added the WebGPU label Aug 28, 2024
@sunag sunag merged commit 8ce2bc4 into mrdoob:dev Aug 28, 2024
12 checks passed
@sunag sunag deleted the dev-viewport branch August 28, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant