Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: getCache() & trackTimestamp check optimization #29245

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

aardgoose
Copy link
Contributor

Two small optimisations.

WebGPU - check if timestamps are available in init() only.

De-proxy node objects in getCache() where TSL magic is not required for cache key generation (#29094) - visible in performance profiles.

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
685.4 kB (169.7 kB) 685.4 kB (169.7 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
462 kB (111.4 kB) 462 kB (111.4 kB) +0 B

@sunag sunag added this to the r168 milestone Aug 28, 2024
@sunag sunag changed the title WebGPURenderer: optimisations WebGPURenderer: Optimizations Aug 28, 2024
@sunag sunag changed the title WebGPURenderer: Optimizations WebGPURenderer: getCache() & trackTimestamp check optimization Aug 28, 2024
@sunag sunag merged commit 4116f84 into mrdoob:dev Aug 28, 2024
12 checks passed
@aardgoose aardgoose deleted the optimisations branch August 28, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants