Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loop bounds in BatchedMesh#computeBoundingBox to properly cover a… #29243

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

gfodor
Copy link
Contributor

@gfodor gfodor commented Aug 27, 2024

Related issue: #29242

Description

Fixes issue with BatchedMesh bounding box computation when instancing geometries.

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
685.4 kB (169.7 kB) 685.4 kB (169.7 kB) -11 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
462 kB (111.4 kB) 462 kB (111.4 kB) +0 B

@gfodor
Copy link
Contributor Author

gfodor commented Aug 27, 2024

cc @gkjohnson

@mrdoob mrdoob added this to the r168 milestone Aug 28, 2024
@mrdoob mrdoob merged commit d02a234 into mrdoob:dev Aug 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants