Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ViewportNode: Clean up #29241

Merged
merged 1 commit into from
Aug 27, 2024
Merged

ViewportNode: Clean up #29241

merged 1 commit into from
Aug 27, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Aug 27, 2024

Related issue: #29211

@sunag sunag marked this pull request as ready for review August 27, 2024 19:18
@sunag sunag changed the title ViewportNode: Cleanup ViewportNode: Clean up Aug 27, 2024
@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
685.4 kB (169.7 kB) 685.4 kB (169.7 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
462 kB (111.4 kB) 462 kB (111.4 kB) +0 B

@sunag sunag added this to the r168 milestone Aug 27, 2024
@sunag sunag merged commit 89407fb into mrdoob:dev Aug 27, 2024
12 checks passed
@sunag sunag deleted the dev-viewport-cleanup branch August 27, 2024 19:56
This was referenced Aug 29, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r168
Development

Successfully merging this pull request may close these issues.
1 participant
@sunag