Nodes: InstancedPointsNodeMaterial - Add pointWidthNode
#29236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmhhelgeson
force-pushed
the
update_instanced_points
branch
from
4246ef5 to
cd55da0
Compare
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
The screenshot appears to be passing in local tests. I've tried passing in a new one, but Git keeps indicating that the new image cannot be pushed in, as it is the same as the current one. EDIT: I think I will just add the example as an exception to puppeteer for now. |
sunag
reviewed
Aug 28, 2024
cmhhelgeson
changed the title
…ssed as a StorageBufferNode in a compute shader
cmhhelgeson
force-pushed
the
update_instanced_points
branch
from
2d66689 to
7770831
Compare
|
Sometimes it is necessary to update the build to take the screenshot. |
sunag
changed the title
InstancedPointsNodeMaterial - Add pointWidthNode
This was referenced Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the ability to apply a per instance size attribute to the InstancedPointsGeometry, and access that attribute within the InstancedPointsNodeMaterial. The existing approach is extended, specifying via parameters that the material should access the instanceSize attribute of the relevant geometry rather than the uniform width value passed directly to the material. However, we could modify the material down the line to use an approach more in line with existing node materials, where the output is modified by applying nodes to the material ( such as a positionNode or sizeNode ) rather than setting static parameters that determine the nodes the material creates internally.
Untitled.video.6.mp4