Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Improve clippingContext cachekey #29232

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

aardgoose
Copy link
Contributor

The current version based cache key generation for clipping contexts has the side effect of creating redundant pipeline objects, eg 9 redundant pipelines for the PMREM generator pass. Fix this with a state based key.

Equivalent changes made to #28237 for ClippingGroups.

Copy link

github-actions bot commented Aug 26, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
685.4 kB (169.7 kB) 685.4 kB (169.7 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
462 kB (111.4 kB) 462 kB (111.4 kB) +0 B

@mrdoob mrdoob added this to the r168 milestone Aug 26, 2024
@mrdoob mrdoob added the WebGPU label Aug 26, 2024
@sunag sunag merged commit 78f2ffb into mrdoob:dev Aug 27, 2024
12 checks passed
@aardgoose aardgoose deleted the clipping-fix branch August 27, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants