WebGPURenderer: Use getPreferredCanvasFormat #29221
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
|
We have tried that before but it was necessary to revert this change, see #28868 (comment), #28876. |
|
@Mugen87 is the issue that the quest browser returns the wrong
Let me know what what you think. |
|
Can you create a function |
sunag
changed the title
|
I love this idea thks
…On Sat 24 Aug 2024 at 15:27, sunag ***@***.***> wrote:
Can you create a function WebGPUUtils.getPreferredCanvasFormat() e apply
the userAgent tests there?
—
Reply to this email directly, view it on GitHub
<#29221 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACKXVQGV6E4URBYNTIIFHLZTCC3NAVCNFSM6AAAAABNAVASE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBYGM4TKNJRGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@sunag I tested this build on our side and it works great, hope you like it too :) |
| @@ -109,6 +109,20 @@ class WebGPUUtils { | |||
|
|
|||
| } | |||
|
|
|||
| getPreferredCanvasFormat() { | |||
|
|
|||
| if ( navigator.userAgent.includes( 'Quest' ) ) { | |||
There was a problem hiding this comment.
FYI @cabanier
Thanks! lgtm
Is this because Quest is returning the wrong preferred format?
There was a problem hiding this comment.
Yes.
Will we be able to remove this check soon?
There was a problem hiding this comment.
Yes.
Will we be able to remove this check soon?
I'll take a look
There was a problem hiding this comment.
Yes.
Will we be able to remove this check soon?
Quest browser after 34.5 will have a fix for this.
@sunag for Three.js to run on Android, BGRA8Unorm is not supported on many adapters. As WebGPU gets deployed on more browsers and more platforms, I suspect that this will be an issues on some browser/platforms combinations as well.