Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Get fallback approach #29218

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Aug 23, 2024

Related issue: Closes #29206 (comment)

Description

Improve fallback approach. No need for top-level await and duplicate adapter.

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
685.4 kB (169.7 kB) 685.4 kB (169.7 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
462 kB (111.4 kB) 462 kB (111.4 kB) +0 B

@sunag sunag marked this pull request as ready for review August 23, 2024 14:48
@sunag sunag added this to the r168 milestone Aug 23, 2024
@sunag
Copy link
Collaborator Author

sunag commented Aug 23, 2024

Let's try 🤞

@sunag sunag merged commit c6d4b83 into mrdoob:dev Aug 23, 2024
12 checks passed
@sunag sunag deleted the dev-getfallback branch August 23, 2024 14:51
@wcandillon
Copy link
Contributor

❤️

threejs.mp4

@sunag
Copy link
Collaborator Author

sunag commented Aug 23, 2024

Amazing!! Thank you for sharing 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants