ShaderNode: Remove .isArrayInput
#29205
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #27426
Description
We are running three.js on a JS engine (Hermes) where
fn.toString()
does not return the source code of the function.You can see a demo here: https://x.com/wcandillon/status/1825862686300672124
This is an alternative implementation of inputs that would fit.
I do have some question:
Array.isArray
which will always return false (but it will not break the code). So there is probably more cleaning up that could be done here (I'm just not sure where).Let me know what you think☺️