Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address feedback on PR #28654 #29190

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Conversation

HunterLarco
Copy link
Contributor

@HunterLarco HunterLarco commented Aug 20, 2024

Description

After being merged, additional feedback was provided on #28654 (see comment)

The example is unfortunately not in an ideal state since a black screen by default isn't good. Instead of using a lil-gui, what do you think about cycling through the layers (1, 2, 3) in a fixed interval?
If the E2E test fails, just add it to the exception list.

Alternatively, I could just initialize the example by writing the first 3 layers to the screen and then letting users navigate the dat.gui. Do you have a preference?

Let's use this approach since webgl_texture2darray_compressed is already animated.

This PR does just that, it updates the example to initialize with the first 3 layers of the spirited away reel.

cc @Mugen87

This contribution is funded by SOOT

@HunterLarco HunterLarco marked this pull request as ready for review August 20, 2024 19:31
@Mugen87 Mugen87 added this to the r168 milestone Aug 20, 2024
@Mugen87 Mugen87 merged commit 4c62a13 into mrdoob:dev Aug 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants