Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: remove redundant code #29186

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

aardgoose
Copy link
Contributor

The currentAnisotropy property is overwritten in createTexture -> backend.set( texture, {} ) after setTextureParameters() is called, so is never useful.

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
685.4 kB (169.7 kB) 685.4 kB (169.7 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
462 kB (111.4 kB) 462 kB (111.4 kB) +0 B

@RenaudRohlinger RenaudRohlinger added this to the r168 milestone Aug 20, 2024
@RenaudRohlinger RenaudRohlinger merged commit 6dd4ddc into mrdoob:dev Aug 20, 2024
12 checks passed
@aardgoose aardgoose deleted the texture-webgl-fix branch August 23, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants