Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Reduce bindingGroup creation for data texture content updates. #29183

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

aardgoose
Copy link
Contributor

The example webgpu_instancing_morph creates a new bindingGroup and textureView each frame when the DataArrayTexture contents are updated, which is redundant.

Rework the conditions for recreating a binding group, such that texture content only changes are ignored.

Also the backend updateBindings() and createBindings() methods do not take a pipeline object, update the base backend class and calling functions.

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
685.4 kB (169.7 kB) 685.4 kB (169.7 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
462 kB (111.4 kB) 462 kB (111.4 kB) +0 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants