XRControllerModelFactory: Prevent hand input source processing. #29179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorodi
changed the title
|
Is there anything else required for this PR? This is my first time contributing here. |
Mugen87
approved these changes
Sep 16, 2024
Mugen87
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the
Could not find xr_standard_trigger_pressed_min in the modelwarning seen in three.js examples that use hand inputs: e.g. webxr_vr_handinput.html.It also prevents unnecessary processing by the device, since
XRControllerModelFactoryis meant for non-hand input sources: i.e. controller models.When hand tracking is enabled for a WebXR capable device and
new XRControllerModelFactory()is used, itsconnectedevent listener does not currently prevent a hand input source from also callingfetchProfile().This adds a check to prevent a hand input source from also calling
fetchProfile().