Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes: Update DotScreenNode, ColorAdjustmentNode, BlendModeNode #29178

Merged
merged 5 commits into from
Aug 19, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Aug 19, 2024

Description

Update to TSL approach and simplification.

@sunag sunag added this to the r168 milestone Aug 19, 2024
Copy link

github-actions bot commented Aug 19, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
685.4 kB (169.7 kB) 685.4 kB (169.7 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
462 kB (111.4 kB) 462 kB (111.4 kB) +0 B

@sunag sunag changed the title Nodes: Update DotScreenNode, ColorAdjustmentNode Nodes: Update DotScreenNode, ColorAdjustmentNode, BlendModeNode Aug 19, 2024
@sunag
Copy link
Collaborator Author

sunag commented Aug 19, 2024

For the same result image

@sunag sunag marked this pull request as ready for review August 19, 2024 17:21
@sunag sunag merged commit d7ba035 into mrdoob:dev Aug 19, 2024
12 checks passed
@sunag sunag deleted the dev-tsl-rev branch August 19, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant