Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Remove curvature estimation demo. #29171

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Aug 19, 2024

Related issue: -

Description

We should revisit some webgl_* examples and decide whether or not the code should be migrated to WebGPURenderer or maybe removed altogether. We can do this in a case-by-case manner.

One demo that I like to suggest to remove is webgl_materials_curvature. It is focused on a very specific topic (curvature estimation) and I suspect it is not clear for most users looking at the demo what it is actually showcasing. Since it also has a dependency to ShaderMaterial, I vote to remove it.

@mrdoob
Copy link
Owner

mrdoob commented Aug 19, 2024

I vote for removing it too 👍

@Mugen87 Mugen87 added this to the r168 milestone Aug 19, 2024
@Mugen87 Mugen87 merged commit 8884f0f into mrdoob:dev Aug 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants