Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPU Renderer: cache GPUBindGroupLayouts #29158

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Conversation

aardgoose
Copy link
Contributor

Currently bindGroups and bindGroupLayouts are creates 1:1. Cache layouts per bindGroup definition, and reused.

webgpu_materials_toons:

layouts without caching 404,
layouts with caching: 6

webgpu_materials_video:

Without caching creates many layouts per frame., with caching 6

Copy link

github-actions bot commented Aug 17, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
685.4 kB (169.7 kB) 685.4 kB (169.7 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
462 kB (111.4 kB) 462 kB (111.4 kB) +0 B

@sunag sunag added this to the r168 milestone Aug 18, 2024
@sunag sunag merged commit 9e7f112 into mrdoob:dev Aug 19, 2024
12 checks passed
@sunag
Copy link
Collaborator

sunag commented Aug 19, 2024

Do you think we still need this workaround? #27447

@aardgoose aardgoose deleted the cache-layouts branch August 20, 2024 10:06
@aardgoose
Copy link
Contributor Author

Do you think we still need this workaround? #27447

Sadly, we still do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants