Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: fix occlusion when rendering to a texture with WebGL fallback #29154

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

aardgoose
Copy link
Contributor

The webgpu_occlusion example is currently broken, the blitFramebuffer operation is included in the scope of the query and produces an incorrect samples_passed count.

Fix this by moving endQuery() before other operations.

Also remove some duplicated consts.

@sunag sunag added this to the r168 milestone Aug 16, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
685.4 kB (169.7 kB) 685.4 kB (169.7 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
462 kB (111.4 kB) 462 kB (111.4 kB) +0 B

@sunag sunag merged commit 5db8c83 into mrdoob:dev Aug 16, 2024
12 checks passed
@aardgoose aardgoose deleted the occlusion-fix branch August 20, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants