Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: WebGL fallback - fix scissor with MSAA #29148

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

aardgoose
Copy link
Contributor

Combining multiple renderpasses and scissoring with msaa can result in invalid framebuffer contents being used.

This is illustrated by the webgpu_textures_anisotropy example using the WebGL fallback renderer.

Apply the scissor coordinates to the framebuffer blit and invalidation operations.

Copy link

github-actions bot commented Aug 15, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
685.4 kB (169.7 kB) 685.4 kB (169.7 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
462 kB (111.4 kB) 462 kB (111.4 kB) +0 B

@Mugen87 Mugen87 added this to the r168 milestone Aug 15, 2024
@Mugen87
Copy link
Collaborator

Mugen87 commented Aug 15, 2024

The CI still seems to complain about the screenshot. I suggest you put the example on the exception list if a regeneration does not work. I'll revisit the exceptions at a later point.

@sunag sunag merged commit 769a82d into mrdoob:dev Aug 16, 2024
12 checks passed
@aardgoose aardgoose deleted the scissor-invalidate branch August 20, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants