WebGPURenderer: New normal nodes approach #29137
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
| @@ -40,7 +39,6 @@ class NodeMaterial extends Material { | |||
|
|
|||
| this.fog = true; | |||
| this.lights = false; | |||
| this.normals = true; | |||
There was a problem hiding this comment.
Glad to see normals is gone! 🎉
Starting from r168, `setupNormal` returns the normal node instead of assigning inside the `NodeMaterial.setupNormal` See: mrdoob/three.js#29137
| import { Fn } from '../../shadernode/ShaderNode.js'; | ||
|
|
||
| const getGeometryRoughness = Fn( () => { | ||
|
|
||
| const dxy = normalGeometry.dFdx().abs().max( normalGeometry.dFdy().abs() ); | ||
| const dxy = normalView.dFdx().abs().max( normalView.dFdy().abs() ); |
There was a problem hiding this comment.
I've noticed that a lot of code relies on normalView for lighting calculations and PBR purposes. However, we can't depend on it as-is because, as far as I understand, normalView is only assigned once using once() and is never reassigned.
This creates a limitation where the node-based approach doesn't seem to fully support normalNode. For example, in the current PR, roughness calculations would only work if there's a roughnessMap. Otherwise, it defaults to using normalView, which is derived from normalLocal rather than normalNode.
If my understanding is correct, normalNode effectively resolves to normalView, making normalNode incompatible with the current node system. Or am I missing something here, @sunag?
There was a problem hiding this comment.
I think you're looking for transformedNormalView. normalView is supposed to keep the geometry normals, so it was used in getGeometryRoughness, while transformedNormalView is affected by normalNode.
I was already thinking about renaming it because the term transformed is uncommon, moving normalView to geometryNormalView and transformedNormalView to normalView, this should be a standard across all nodes.
Related issue: Closes #28939, #29121
Description
Thanks to the once deferred function we can use constants as functions that will be executed at compile time. This approach is superior to the current ones that use
transformedNormalView.assign()and I think we can use it not so soon inpositionLocalandpositionPreviousas well.