WebGPURenderer: WebGL State improvements #29132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
reviewed
Aug 14, 2024
|
|
||
| } else { | ||
|
|
||
| console.warn( 'bindBufferRange is only applicable for uniform buffers' ); |
There was a problem hiding this comment.
It would be good to always add the component to the message that logs it. E.g.:
console.warn( 'THREE.WebGLBackend: bindBufferRange() is only applicable for uniform buffers.' );There was a problem hiding this comment.
Oops, actually _bindBufferRange was a method I forgot to cleanup that I will work on later on, also I don't think internal warning is useful. Thanks for the heads up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #27388
Next is about moving
VAOinto a newWebGLBindingStatesclass and handle the binding of buffers to a state comparator too.This contribution is funded by Utsubo