Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effects: Use FullScreenQuad. #29126

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Effects: Use FullScreenQuad. #29126

merged 1 commit into from
Aug 13, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Aug 13, 2024

Related issue: -

Description

AnaglyphEffect and ParallaxBarrierEffect can make use of FullScreenQuad which simplifies the code a bit.

Besides, the PR adds the missing dispose() method to ParallaxBarrierEffect.

@Mugen87 Mugen87 added this to the r168 milestone Aug 13, 2024
@Mugen87
Copy link
Collaborator Author

Mugen87 commented Aug 13, 2024

BTW: I think we can port StereoEffect, AnaglyphEffect and ParallaxBarrierEffect as StereoPassNode, AnaglyphPassNode and ParallaxBarrierPassNode in nodes/display. They would be used via PostProcessing like so:

postProcessing = new THREE.PostProcessing( renderer );

const stereoScenePass = stereoPass( scene, camera );
// const anaglyphScenePass = anaglyphPass( scene, camera );
// const parallaxBarrierScenePass = parallaxBarrierPass( scene, camera );

postProcessing.outputNode = stereoScenePass;

@Mugen87 Mugen87 merged commit 90c34c0 into mrdoob:dev Aug 13, 2024
11 checks passed
@mrdoob
Copy link
Owner

mrdoob commented Aug 14, 2024

BTW: I think we can port StereoEffect, AnaglyphEffect and ParallaxBarrierEffect as StereoPassNode, AnaglyphPassNode and ParallaxBarrierPassNode in nodes/display.

Agreed! And would be great to remove these files eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants