StereoEffect: Handle clear differently. #29125
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
I was testing what type of effects already work with
WebGPURenderer
(it'sAsciiEffect
andPeppersGhostEffect
, btw).StereoEffect
does not work because of the way the clear happens inrender()
.When defining a scissor area, WebGL honors it during the clear. That does not work with WebGPU where the clear value is loaded for the entire framebuffer.
StereoEffect
clears now the entire framebuffer once before rendering the left and right view.