Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewportDepthNode: Fix material.depthNode=depth assign #29116

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Aug 12, 2024

Related issue: #28720

Description

The value of depth was incorrect because generate() was overwriting it.

@sunag sunag added this to the r168 milestone Aug 12, 2024
Copy link

github-actions bot commented Aug 12, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
685.1 kB (169.6 kB) 685.1 kB (169.6 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
462 kB (111.4 kB) 462 kB (111.4 kB) +0 B

@sunag sunag marked this pull request as ready for review August 12, 2024 02:55
@sunag sunag merged commit 90160e9 into mrdoob:dev Aug 12, 2024
12 checks passed
@sunag sunag deleted the dev-depth branch August 12, 2024 03:03
@sunag
Copy link
Collaborator Author

sunag commented Aug 12, 2024

I fixed E2E tests here 0c33556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant