Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPUPipelineUtils: Fix blending with premultiplied alpha. #29100

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Aug 9, 2024

Related issue: -

Description

While implementing SSAAPassNode, I've noticed that additive blending with premultiplied alpha isn't correct. This looks like a copy/past error.

@Mugen87 Mugen87 added this to the r168 milestone Aug 9, 2024
Copy link

github-actions bot commented Aug 9, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
685.1 kB (169.6 kB) 685.1 kB (169.6 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
462 kB (111.4 kB) 462 kB (111.4 kB) +0 B

@WestLangley
Copy link
Collaborator

Yikes! Premultiplied NormalBlending is incorrect, too.

@Mugen87 Mugen87 changed the title WebGPUPipelineUtils: Fix additive blending with premultiplied alpha. WebGPUPipelineUtils: Fix blending with premultiplied alpha. Aug 9, 2024
@Mugen87 Mugen87 merged commit 2d6bf90 into mrdoob:dev Aug 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants