Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: Simplify nomenclature #29093

Merged
merged 1 commit into from
Aug 9, 2024
Merged

src: Simplify nomenclature #29093

merged 1 commit into from
Aug 9, 2024

Conversation

WestLangley
Copy link
Collaborator

OptimizedCineonToneMapping => CineonToneMapping

This change is internal to the library. Externally, it remains THREE.CineonToneMapping.

There is no need to have two names referring to the same thing.

This tone mapping function is from a 2010 SIGGRAPH course, and does not appear to be standardized.

@WestLangley WestLangley added this to the r168 milestone Aug 9, 2024
Copy link

github-actions bot commented Aug 9, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
685.1 kB (169.6 kB) 685.1 kB (169.6 kB) -18 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
462 kB (111.5 kB) 462 kB (111.4 kB) -18 B

@Mugen87 Mugen87 merged commit 7b69002 into mrdoob:dev Aug 9, 2024
12 checks passed
@WestLangley WestLangley deleted the dev-cineon branch August 9, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants