ToneMappingNode: Adhere to consistent capitalization

[WestLangley]

Nomenclature differed from that of WebGLRenderer.

[github-actions]

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev	Filesize PR	Diff
685.1 kB (169.6 kB)	685.1 kB (169.6 kB)	+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev	Filesize PR	Diff
462 kB (111.5 kB)	462 kB (111.5 kB)	+0 B

[WestLangley]

@sunag
@Mugen87

On a related note, the following line is never executed:

three.js/src/nodes/display/ToneMappingNode.js

Line 208 in f71cb7a

console.error( 'ToneMappingNode: Unsupported Tone Mapping configuration.', toneMapping );

due to

three.js/src/nodes/display/ToneMappingNode.js

Line 198 in f71cb7a

const toneMappingNode = toneMappingLib[ toneMapping ];

It defaults to NoToneMapping without warning.

Any suggestions as to the best way to fix this?

[sunag]

On a related note, the following line is never executed:

I think this warning would help in case the user uses a new tonemapping on an older version of three.js.

[WestLangley]

@sunag I think the default value for toneMapping in the constructor prevents toneMappingNode from being undefined.

[sunag]

Oh right, this default value doesn't seem to make much sense, I think we can remove it.

[WestLangley]

@sunag OK. And one more question... is a custom tone mapping node with user-specified TSL supported for WebGPURenderer?

[sunag]

@sunag OK. And one more question... is a custom tone mapping node with user-specified TSL supported for WebGPURenderer?

Yes, we had renderer.toneMappingNode but after PostProcessing it seemed better to remove it in order to simplifying the renderer, this could be implemented in PostProcessing via Fn() / Node.