Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Add viewportSafeUV in webgpu_backdrop #29067

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Aug 5, 2024

Related issue: #29025

Description

Improve the example and add good practices.

@sunag sunag marked this pull request as ready for review August 5, 2024 17:40
@sunag sunag added this to the r168 milestone Aug 5, 2024
@sunag sunag changed the title Examples: Add 'viewportSafeUV' in webgpu_backdrop Examples: Add viewportSafeUV in webgpu_backdrop Aug 5, 2024
@sunag sunag merged commit fdd64a8 into mrdoob:dev Aug 5, 2024
11 checks passed
@sunag sunag deleted the dev-backdrop-rev branch August 5, 2024 17:59
@wcandillon
Copy link
Contributor

@sunag when using this new node, I am getting the following validation error:

Validation: Source [Texture (unlabeled 393x754 px, TextureFormat::Depth24Plus)] sample count (4) and destination [Texture (unlabeled 393x754 px, TextureFormat::Depth24Plus)] sample count (1) does not match.

Any chance you could help find the underlying API call and maybe root cause of the issue? I would love to debug this further.

@wcandillon
Copy link
Contributor

The issue might be on our side but I am wondering if you could set me in the right direction

@sunag
Copy link
Collaborator Author

sunag commented Sep 11, 2024

WebGPU needs specific methods to deal with sampled textures and this has not been implemented yet, WebGPURenderer( { antialias: false } ) will help solve these issues until we improve this support.

@wcandillon
Copy link
Contributor

thank you for providing this context, appreciate it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants