Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatchedMesh: fix colorsTexture size #29061

Merged
merged 1 commit into from
Aug 5, 2024
Merged

BatchedMesh: fix colorsTexture size #29061

merged 1 commit into from
Aug 5, 2024

Conversation

agargaro
Copy link
Contributor

@agargaro agargaro commented Aug 4, 2024

Description

The size of colorsTexture is bigger than necessary because it is created to store a color for each geometry index, instead of for each instance.

Copy link

github-actions bot commented Aug 4, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
684 kB (169.4 kB) 684 kB (169.4 kB) +3 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
460.9 kB (111.2 kB) 460.9 kB (111.2 kB) +0 B

@mrdoob mrdoob requested a review from gkjohnson August 4, 2024 23:16
Copy link
Collaborator

@gkjohnson gkjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like this was a merge oversight from #28462.

The color texture should provide provide attributes for all instances, as the matrices textures does.

@Mugen87 Mugen87 merged commit 239b639 into mrdoob:dev Aug 5, 2024
12 checks passed
@Mugen87 Mugen87 added this to the r168 milestone Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants