Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Improve webgpu_morphtargets_face. #29047

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Aug 1, 2024

Related issue: -

Description

This makes sure RoomEnvironment is used in at least one WebGPU example to demonstrate that it works with PMREMGenerator.fromScene(). This restores the original looks of webgpu_morphtargets_face.

//head.morphTargetInfluences = null;

// WebGPURenderer: Unsupported texture format. 33776
head.material.map = null;
Copy link
Collaborator Author

@Mugen87 Mugen87 Aug 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not necessary anymore since KTX2Loader uses WebGPU compatible formats now, see #28069.

@Mugen87 Mugen87 added this to the r168 milestone Aug 1, 2024
@Mugen87 Mugen87 merged commit 1ae17a6 into mrdoob:dev Aug 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant