Material: Add onBeforeRender()
back.
#29043
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #28702
Description
After deprecating
Material.onBeforeRender()
via #28702 multiple devs complained about this change.As compromise I suggest to restore
onBeforeRender()
but make it absolutely clear that this callback will only be supported withWebGLRenderer
. Similar toonBeforeCompile()
.WebGPURenderer
with its node material provide alternative workflows.I've added a comment about this in the documentation and the code (just to be on the safe side).