Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Add Korean language. #29022

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Conversation

shinjeongmin
Copy link
Contributor

@shinjeongmin shinjeongmin commented Jul 30, 2024

hello, i'm Korean user of three.js

I'm using the three.js editor, and I think it would be great if we could use the UI text in Korean for the Korean users.

So, I checked the editor code, added a Korean (kr) language option in the sidebar settings script, and translated the corresponding texts in the Strings script to Korean.

There are quite a few Korean users who use the three.js editor, and I hope accept my suggestion to make it more convenient for them.

Below screenshots are from testing the code modifications I made on local.

※ It seems I made a mistake by committing directly to the dev branch and submitting a pull request without creating a new branch. I'm resubmitting it.

Modify

I was looking into contributions related to Korean translations and found that there is an ISO standard for Korean. I have made the necessary corrections accordingly.
changed kr -> ko according ISO standard #20877 (comment)

image

image
image
image

@shinjeongmin shinjeongmin changed the title Editor: add editor settings korean language. Editor: (re) add editor settings korean language. Jul 30, 2024
@shinjeongmin shinjeongmin changed the title Editor: (re) add editor settings korean language. Editor: add editor settings korean language. Jul 30, 2024
@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 31, 2024

The following line needs an update as well:

const suggestedLanguage = [ 'fr', 'ja', 'zh' ].includes( userLanguage ) ? userLanguage : 'en';

When kr is added, Korean will automatically be selected as the default when the browser's language setting is Korean.

@shinjeongmin
Copy link
Contributor Author

shinjeongmin commented Jul 31, 2024

thanks! I didn't realize that navigator.language was located there.
I tested suggested language to 'ko' and it was well.
When I started three.js editor, it shows text to korean to me!

@Mugen87 Mugen87 added this to the r168 milestone Jul 31, 2024
@Mugen87 Mugen87 changed the title Editor: add editor settings korean language. Editor: Add Korean language. Jul 31, 2024
@Mugen87 Mugen87 merged commit b04c758 into mrdoob:dev Jul 31, 2024
11 checks passed
@shinjeongmin shinjeongmin changed the title Editor: Add Korean language. Editor: Add Korean language to settings options. Aug 1, 2024
@shinjeongmin shinjeongmin changed the title Editor: Add Korean language to settings options. Editor: Add Korean language to sidebar settings options. Aug 1, 2024
@shinjeongmin shinjeongmin changed the title Editor: Add Korean language to sidebar settings options. Editor: Add Korean language. Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants