Examples: Add TSL VFX Tornado #29020
Conversation
|
Just thinking out loud... Each three.js example should demonstrate a three.js feature. They are not simply showcases. I wonder if this example should be renamed ... or any one of many other reasonable options... |
|
The idea behind @brunosimon's I also think we should not take the existing example policy too strict in this case. We need visual striking examples for promoting the new material system and renderer. |
Well, at least you admit we have an existing policy. By choosing not to adhere to it, the policy becomes meaningless for the rest of us.
|
|
I think the example is intended to show the tornado, the bloom would just be a graphical enhancement but not mandatory. |
"tornado" is not a feature of three.js. |
Earth, smoke, galaxy are not either. The examples are based on showing how to do this using TSL. |
I hope I'm not speaking out of turn here, but I think @WestLangley would find issue with those names as well, which also do not follow the previous policy. I don't believe he is discounting the need for visually arresting samples that demonstrate the new node system, nor that there's no benefit to a wide range of samples, just that the naming of the samples should more directly address or specify the sample's predominantly utilized feature set. I think this issue could be easily addressed by appending additional keywords to the existing names. For instance, we have multiple compute particle samples that technically address the same features, but each example is still prefixed with "webgpu_compute_particles" to directly indicate what feature set the example primarily addresses. |
I think we are not straying from this logic, we have 150~ tornado lines vs 1 bloom line. If I agree with the tags I think is a good idea, regardless of the names. |
I think we're still getting hung up on a specific suggestion rather than the broad principle behind the suggestion. Perhaps "bloom" is not the proper identifier for the tornado sample. It could be geometry, points, perlin, textures, luminance, anything that is truly relevant to the example. But naming the sample tornado, while accurate to the sample's intended functionality, nullifies the sample's effectiveness to the website's initial viewer as a reference for anything other than itself. It may be impossible to peg a given sample's utility down to a single feature set, but it's at least worth having the discussion on more effective names before that determination is made. |
If you want to add additional information to an example, you can use the tag mechanism. In this way, e.g if you search for "bloom", all examples pop up that have "bloom" as a tag. Tags are maintained here: https://github.com/mrdoob/three.js/blob/dev/examples/tags.json |
Agreed. I think having some complex examples showing how to use TSL is good. As a reminder, in the old days we used to have complex examples like this too but they were hard to maintain because they used a lot of custom GLSL. Thanks to TSL we shouldn't have maintenance issues this time 🤞 |
Description
Adds WebGPU/TSL VFX Tornado example.
I included the post processing bloom.
I added the screenshot to the exceptions since I can't generate one that works with the tests.