Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Add debug.getRawShaderAsync(). #28997

Merged
merged 2 commits into from
Jul 27, 2024
Merged

WebGPURenderer: Add debug.getRawShaderAsync(). #28997

merged 2 commits into from
Jul 27, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 27, 2024

Fixed #28984.

Description

This PR fixes webgpu_tsl_editor by adding rendererer.debug.getRawShader() which allows to get the raw shader (WGSL or GLSL) for a 3D object.

@Mugen87 Mugen87 added this to the r168 milestone Jul 27, 2024
Copy link

github-actions bot commented Jul 27, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
684 kB (169.4 kB) 684 kB (169.4 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
460.9 kB (111.2 kB) 460.9 kB (111.2 kB) +0 B

@sunag sunag changed the title WebGPURenderer: Add debug.getRawShader(). WebGPURenderer: Add debug.getRawShaderAsync(). Jul 27, 2024
@sunag sunag merged commit 873c9d5 into mrdoob:dev Jul 27, 2024
12 checks passed
@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jul 27, 2024

@sunag Nice solution! 🙌

brunosimon pushed a commit to brunosimon/three.js that referenced this pull request Jul 28, 2024
* WebGPURenderer: Add `debug.getRawShader()`.

* Added getRawShaderAsync()

---------

Co-authored-by: sunag <[email protected]>
@mrdoob
Copy link
Owner

mrdoob commented Jul 29, 2024

Maybe getShaderAsync() instead?
Do we need the Raw concept now that we are using nodes?

@Mugen87 Mugen87 changed the title WebGPURenderer: Add debug.getRawShaderAsync(). WebGPURenderer: Add debug.getShaderAsync(). Aug 11, 2024
@Mugen87 Mugen87 changed the title WebGPURenderer: Add debug.getShaderAsync(). WebGPURenderer: Add debug.getRawShaderAsync(). Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSL Editor Example: Does not work because of 404 of three JS files
3 participants