NodeEditor: Make sure scene is properly resetted. #28992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
commented
Jul 26, 2024
| @@ -200,6 +200,8 @@ export class ScriptableEditor extends BaseNodeEditor { | |||
|
|
|||
| disposeScene( editorOutputAdded ); | |||
There was a problem hiding this comment.
This name is a bit misleading. editorOutputAdded is not a scene so disposeScene() usually operates on a mesh. Hence, I had to introduce a separate resetScene().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
When working at #28987 I've realized the examples using the basic material did not look right.
The default teapot example defines an environment for its standard material. When you now switch to an example using the basic material, the environment is applied as well since the texture is never removed. That also happened in previous releases however the issue wasn't noticed since the basic material did not support env maps.