Background: Fix update when changing env map. #28966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
commented
Jul 25, 2024
src/renderers/common/Background.js
Outdated
| @@ -89,8 +85,11 @@ class Background extends DataMap { | |||
|
|
|||
| if ( sceneData.backgroundCacheKey !== backgroundCacheKey ) { | |||
|
|
|||
| sceneData.backgroundMeshNode.node = vec4( backgroundNode ).mul( backgroundIntensity ); | |||
| const backgroundMeshNode = getBackgroundMeshNode( backgroundNode ); | |||
There was a problem hiding this comment.
@sunag Maybe there is a better way to fix this but using a fresh backgroundMeshNode the material is properly updated.
There was a problem hiding this comment.
Many of the current issues are related to #27904, the improvement brought better performance but broke some features that need to be reviewed.
Maybe just adding a node.needsUpdate could solve the problem?
sceneData.backgroundMeshNode.needsUpdate = true;if ( sceneData.backgroundCacheKey !== backgroundCacheKey ) {
sceneData.backgroundMeshNode.node = vec4( backgroundNode ).mul( backgroundIntensity );
sceneData.backgroundMeshNode.needsUpdate = true;
backgroundMesh.material.needsUpdate = true;
sceneData.backgroundCacheKey = backgroundCacheKey;
}There was a problem hiding this comment.
Indeed, that fixes it! I'll update the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
Similar to
WebGLRenderer,WebGPURenderershould automatically update the background when the environment map assigned toScene.backgroundchanges. The existing check inBackgroundwas not 100% correct.For reproduction: https://jsfiddle.net/1pxtb75k/ (the background does not change to the equirect version)