Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScriptableNode: Fix getCacheKey() #28964

Merged
merged 1 commit into from
Jul 25, 2024
Merged

ScriptableNode: Fix getCacheKey() #28964

merged 1 commit into from
Jul 25, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jul 25, 2024

Related issue: Closes #28960

Description

Fix getCacheKey().

@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
684 kB (169.4 kB) 684 kB (169.4 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
460.9 kB (111.2 kB) 460.9 kB (111.2 kB) +0 B

@sunag sunag marked this pull request as ready for review July 25, 2024 05:35
@sunag sunag merged commit 60a1f06 into mrdoob:dev Jul 25, 2024
12 checks passed
@sunag sunag added this to the r167 milestone Jul 25, 2024
@sunag sunag deleted the dev-fix-getcachekey branch July 25, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r167
Development

Successfully merging this pull request may close these issues.

Examples: webgpu_materials.html is rendering material as black
1 participant
@sunag