Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes: More serialization/deserialization fixes. #28946

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 23, 2024

Fixed #28933.

Description

This PR adds the scriptableNode material back in webgpu_materials and fixes the actual root cause of #28933.

TextureNode and UniformGroupNode had an incomplete serialization/deserialization.

@Mugen87 Mugen87 added this to the r167 milestone Jul 23, 2024
Copy link

github-actions bot commented Jul 23, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
684 kB (169.4 kB) 684 kB (169.4 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
460.9 kB (111.2 kB) 460.9 kB (111.2 kB) +0 B

@Mugen87 Mugen87 merged commit ebc60a5 into mrdoob:dev Jul 23, 2024
10 of 11 checks passed
@@ -370,7 +370,7 @@

//

// setTimeout( () => testSerialization( serializeMesh ), 1000 ); // FIXME, see #28933
setTimeout( () => testSerialization( serializeMesh ), 1000 ); // FIXME, see #28933
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mugen87 Do you need to remove the inline comment?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is rendering a black teapot on a black background. It does not appear to be working as intended...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is an issue with the material but this should be unrelated to serialization/deserialization. Probably best to file a separate issue for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebGPURenderer: errors thrown
2 participants