AttributeNode: Fix serialization/deserialization. #28944
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #28943
Description
The serialization/deserialization of node materials relying on
AttributeNode
fails at the moment.Fiddle for reproduction: https://jsfiddle.net/anqx4whk/
The PR overwrites
Node.serialize()
andNode.deserialize()
and honors the missing properties.@sunag Is this the right approach? When I understand the code in the upper class correctly, private properties and properties holding primitive values are not honored so far and must be handled in the sub class.