NodeMaterial: Add setupOutgoingLight().
#28941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
commented
Jul 23, 2024
| @@ -41,7 +41,7 @@ class NodeMaterial extends Material { | |||
| this.forceSinglePass = false; | |||
|
|
|||
| this.fog = true; | |||
| this.lights = true; | |||
| this.lights = false; | |||
There was a problem hiding this comment.
Probably better to set lights to false by default since we should not assume all custom node materials implement proper lighting models.
There was a problem hiding this comment.
I think we should do this with fog too.
There was a problem hiding this comment.
Let's do that in a separate PR though. The testing for such changes can take a bit time.
This was referenced Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
Lit materials like lambert, phong or standard should be black if no lights are in the scene and no emissive is defined. This is currently not true for node materials since
diffuseColor.rgbis defined as the default outgoing light.For reproduction: https://jsfiddle.net/5kat2bom/1/
This issue is solved by adding
setupOutgoingLight()which checks iflightsis set totrue. If so, the default outgoing light is black. Otherwise it isdiffuseColor.rgb. The code is not inlined but insetupOutgoingLight()soMeshBasicNodeMaterialcan overwrite the implementation.