Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPUBindingUtils: Define sampleType for all data textures consistently. #28940

Merged
merged 1 commit into from
Jul 22, 2024
Merged

WebGPUBindingUtils: Define sampleType for all data textures consistently. #28940

merged 1 commit into from
Jul 22, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 22, 2024

Fixed #28921.

Description

The sampleType (a property of GPUTextureBindingLayout) is now defined consistently for all data texture types.

@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
684 kB (169.4 kB) 684 kB (169.4 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
460.9 kB (111.2 kB) 460.9 kB (111.2 kB) +0 B

@Mugen87 Mugen87 added this to the r167 milestone Jul 22, 2024
@sunag sunag merged commit a00f79b into mrdoob:dev Jul 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r167
Development

Successfully merging this pull request may close these issues.

examples/webgpu_morphtargets_face.html uses rgba32-float filtering textures without checking feature
2 participants
@Mugen87 @sunag