Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaterialNode: Honor emissiveIntensity. #28924

Merged
merged 2 commits into from
Jul 20, 2024
Merged

MaterialNode: Honor emissiveIntensity. #28924

merged 2 commits into from
Jul 20, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 20, 2024

Related issue: -

Description

This PR makes sure emissiveIntensity is honored in WebGPURenderer.

The floating crystal in webgpu_postprocessing_pixel had no pulse effect so far which should now be fixed. It also fixes the lamp in webgpu_loader_gltf_anisotropy.

@Mugen87 Mugen87 added this to the r167 milestone Jul 20, 2024
Copy link

github-actions bot commented Jul 20, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
683.7 kB (169.3 kB) 683.7 kB (169.3 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
460.9 kB (111.2 kB) 460.9 kB (111.2 kB) +0 B

@Mugen87 Mugen87 merged commit 216398f into mrdoob:dev Jul 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant