GLSLNodeBuilder: Remove Int16Array check from getTypeFromAttribute().
#28920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
commented
Jul 19, 2024
| @@ -476,7 +476,7 @@ ${ flowData.code } | |||
|
|
|||
| const array = dataAttribute.array; | |||
|
|
|||
| if ( ( array instanceof Uint32Array || array instanceof Int32Array || array instanceof Int16Array ) === false ) { | |||
| if ( ( array instanceof Uint32Array || array instanceof Int32Array ) === false ) { | |||
There was a problem hiding this comment.
@sunag I do not fully understand why getTypeFromAttribute() needs to modify the data type of the attribute in the shader based on the geometry data array type. I think it would be best to generate the correct data type in the shader code right from the beginning.
iuvec* types should only be generated when attribute.gpuType === IntType or when the geometry data array is of type Uint32Array or Int32Array.
There was a problem hiding this comment.
Ok for me, I don't remember exactly when this was done, so you can proceed as you see fit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #28918
Description
Int16Arrayorgl.SHORTis a float type by default inWebGLRenderer. It is only interpreted as integer input for attributes in the vertex shader ifattribute.gpuTypeisIntType.