Nodes: Rename uniforms() to uniformArray().
#28910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
|
Wouldn't be |
|
Class name should follow the TSL method too like |
Mugen87
approved these changes
Jul 19, 2024
sunag
changed the title
cmhhelgeson
force-pushed
the
webgpu_uniforms_name_change
branch
from
0d8d454 to
71f183a
Compare
|
None of the r168 additions after rebase seem to necessitate additional changes to this branch. |
Mugen87
changed the title
uniforms() to uniformArray().
brunosimon
pushed a commit
to brunosimon/three.js
that referenced
this pull request
Jul 28, 2024
* init branch * Change class naming to match function
This was referenced Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #28878
Related PR: #28897
Description
Rename the UniformsNode's uniforms() function to uniformArray(). This better communicates the difference in functionality and expected argument types between the uniform() and uniforms() functions.