Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes: Add BloomNode. #28903

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Nodes: Add BloomNode. #28903

merged 3 commits into from
Jul 17, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 17, 2024

Related issue: -

Description

This PR ports UnrealBloomPass to WebGPURenderer by adding BloomNode.

Note: The blend of the bloom now handles premultiplied alpha correctly. I've originally wanted to fix this via #26185 but did not merge the PR for backwards compatibility reasons. The new default bloom strength is now a bit weaker than before.

@Mugen87 Mugen87 added this to the r167 milestone Jul 17, 2024
Copy link

github-actions bot commented Jul 17, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
683.4 kB (169.2 kB) 683.4 kB (169.2 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
460.5 kB (111.1 kB) 460.5 kB (111.1 kB) +0 B

@Mugen87 Mugen87 merged commit bdc6485 into mrdoob:dev Jul 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant