Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLTFExporter: Set willReadFrequently to true when using canvas2d. #28893

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

myznikovgleb
Copy link
Contributor

@myznikovgleb myznikovgleb commented Jul 16, 2024

Fixed #28887

Description

According to spec, GLTFExporter addon has been missing willReadFrequently context attribute set true for every getContext call. It leads to poor exporting performance and annoying warnings appearance. Changes solve it both. The last one, at least

@Mugen87 Mugen87 added this to the r167 milestone Jul 16, 2024
@Mugen87 Mugen87 changed the title feat-gltf-exporter: Set context attributes for getContext calls GLTFExporter: Set willReadFrequently to true when using canvas2d. Jul 16, 2024
@Mugen87 Mugen87 merged commit 0a7f9b6 into mrdoob:dev Jul 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GLTF Export Optimization
2 participants