Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Clean up. #28891

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Core: Clean up. #28891

merged 1 commit into from
Jul 16, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 16, 2024

Related issue: -

Description

This PR improves the code style of the new core classes by:

  • adding the /*@__PURE__*/ annotation where it is required and
  • using the _ for module scope variables.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 16, 2024 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
683.5 kB (169.2 kB) 683.5 kB (169.2 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
460.7 kB (111.1 kB) 460.7 kB (111.1 kB) +0 B

@Mugen87 Mugen87 added this to the r167 milestone Jul 16, 2024
@Mugen87 Mugen87 merged commit dd9f4c1 into mrdoob:dev Jul 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r167
Development

Successfully merging this pull request may close these issues.
1 participant
@Mugen87