Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box2, Box3: Escape ternary condition in "intersectsBox" method #28872

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

satelllte
Copy link
Contributor

Description

If you decide to include #28871, this follow up change flips the last condition ? false : true kind of ternary condition in the ./src directory of this codebase

@satelllte satelllte changed the title Box2, Box3: intersectsBox - flip condition implementation Box2, Box3: Escape ternary condition in "intersectsBox" method Jul 14, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
683.5 kB (169.2 kB) 683.5 kB (169.2 kB) +6 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
460.7 kB (111.1 kB) 460.7 kB (111.1 kB) +4 B

@satelllte satelllte marked this pull request as ready for review July 14, 2024 19:22
@Mugen87 Mugen87 added this to the r167 milestone Jul 15, 2024
@Mugen87 Mugen87 merged commit 91f0857 into mrdoob:dev Jul 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants