Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Adjust UltraHDRLoader color grading #28845

Merged

Conversation

mjurczyk
Copy link
Contributor

@mjurczyk mjurczyk commented Jul 10, 2024

Related issue: #28825 (comment)

Description

  • Adjusts color grading in UltraHDRLoader
  • Move XMP validation to reduce string encodings

@mrdoob
Copy link
Owner

mrdoob commented Jul 10, 2024

Lets not add more .hdr files 😅

@mrdoob mrdoob added this to the r167 milestone Jul 10, 2024
@mrdoob
Copy link
Owner

mrdoob commented Jul 10, 2024

  • Adds Venice Sunset as example HDR / UltraHDR textures (venice sunset uses a bit more focused light, making it easier to debug lower exposures than with the spruit sunrise.)
  • Adds RGBELoader / UltraHDR toggle to the example

Can you remove these changes from this PR? Lets just focus on fixing UltraHDRLoader.js.

@mjurczyk mjurczyk force-pushed the mjurczyk/ultra-hdr-loader-color-loop-adjustments branch from 38c0603 to cc07672 Compare July 10, 2024 19:02
@mjurczyk
Copy link
Contributor Author

Done 👌

@mrdoob mrdoob merged commit 6e78e3b into mrdoob:dev Jul 10, 2024
11 checks passed
@mjurczyk mjurczyk deleted the mjurczyk/ultra-hdr-loader-color-loop-adjustments branch July 10, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants