MeshBasicNodeMaterial: Fix transformedNormalView.
#28839
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
| @@ -16,7 +16,7 @@ class MeshBasicNodeMaterial extends NodeMaterial { | |||
| this.isMeshBasicNodeMaterial = true; | |||
|
|
|||
| this.lights = true; | |||
| //this.normals = false; @TODO: normals usage by context | |||
There was a problem hiding this comment.
normals usage by context
I could not find reference of normal usage over the context object. Is this TODO still relevant?
There was a problem hiding this comment.
The reason was to remove some possible duplicate operations in normals that might occur in this configuration.
There was a problem hiding this comment.
If you can share an example where duplicate operations might occur, I would be curious to debug this situation 🤓 .
Otherwise I think we should ensure the correct feature set of the materials first before we apply optimizations. Right now, you could apply a normal map to MeshBasicMaterial and it would affect the environment map sampling which isn't ideal.
There was a problem hiding this comment.
If you can share an example where duplicate operations might occur, I would be curious to debug this situation
I think it might take a while for me to check this since it would be easier for me to do the tests again than to find the files.
you could apply a normal map to MeshBasicMaterial and it would affect the environment map sampling which isn't ideal.
For this case I would suggest create a MeshBasicNodeMaterial.setupNormal() for modify this default behavior.
There was a problem hiding this comment.
Okay, there is now an overwritten version of setupNormal() in MeshBasicNodeMaterial next to a comment that refers to this PR.
Mugen87
changed the title
normals to false.transformedNormalView.
Related issue: -
Description
This makes sure
MeshBasicNodeMaterialdoes not react on normal or bump maps by overwriting the computation oftransformedNormalView.