Examples: scroll to currently selected example in the sidebar #28837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
Jul 9, 2024
John-Simth
added a commit
to John-Simth/three.js
that referenced
this pull request
Jul 10, 2024
This reverts commit 4ce3b36.
mrdoob
pushed a commit
that referenced
this pull request
Jul 10, 2024
Co-authored-by: aardgoose <[email protected]>
|
It seems this PR broke the menu bar on mobile devices. This can be reproduced with Chrome dev tools (device mode). Prod: https://threejs.org/examples/index.html#webgl_animation_keyframes 
One commit before merge: https://rawcdn.githack.com/mrdoob/three.js/ad94b23dbfe9ad8242154e548bbf9af9746820e8/examples/index.html#webgl_animation_keyframes 
|
|
I have reverted the change in the |
Mugen87
added a commit
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an example is selected in the sidebar, and the page is refreshed, the sidebar reverts to the default positioning,
Scroll the sidebar so that the selected example name and thumbnail are visible.